MUI: API Functions for a 'back' button

microbmen commented 4 months ago

Hello @olikraus ,

I have implemented up and down buttons, prevField and nextField respectively.
I have implemented a select button, sendSelect,

What I cant figure out is how to implement a back button.

Requirement: API call which does a sendBack() function, returning to the previous MUI_FORM on the previous cursor position.

We can use gotoForm as a back button, and track the form ID needed depending on the current form displayed, however gotoForm requires an initial position, which gives odd UI/UX performance.
An API call for currentCursor(), currentForm(), would also suffice, as then we could retain the position and form independent and use gotoForm anyway we'd like.

Unless I am missing something, this seems to be a needed feature for 4 button control (up/down , previous/next)

Thanks!

qianfan-Zhao commented 4 months ago

I am learing 'mui' example this days. All the menu entry has a ui return button such as this example:

/* number entry demo */
MUI_FORM(10)
MUI_STYLE(1)
MUI_LABEL(5,10, "Number Menu")
MUI_XY("HR", 0,13)
MUI_STYLE(0)

MUI_LABEL(5,27, "Number [mse]:")
MUI_XY("IN",76, 27)
MUI_LABEL(5,41, "Number [mud]:")
MUI_XY("IH",76, 41)

MUI_XYAT("G1",64, 59, 0, " OK ")

The last line MUI_XYAT has a pointer value set which form will return to when this button is pressed, seems all the menu entries use this button to return to it's parent, I can not find an example which use hardware 'backup' button handle it.

I am interesting how to add a hardware backup button, maybe we can take more discussion.

qianfan-Zhao commented 3 months ago

@microbmen Hi, I pushed a new PR #2479 try add back button, could you please try it?

microbmen commented 3 months ago

ok, will try it. i created a work around by setting a 'current menu' flag using MUI_AUX and then using gotoform.

olikraus commented 3 months ago

Currently I do hesitate to include the above mentioned PR, because there is already a little bit of code, which should support this. I also think, that the cursor topic is not addressed by pr #2479 . Let me look into this a little bit deeper.

olikraus commented 3 months ago

Let me give a small background on this topic. There are two concepts in u8g2:

There is a cache concept, which stores the cursor position along with the form id. The idea is, that if you jump to a specific form, then the cursor position is automatically restored. However the current cache size is very small but could be easily extended: https://github.com/olikraus/u8g2/blob/a5f674fedd5e75e71389e6ad2531363b654bdf76/csrc/mui.h#L226 Maybe your problem is already solved by increasing this value
Other concept is an automatic jump back to the previous form and cursor position. At the moment there is just one level of jump back, which is used by the parent / child menus (like the combo menu). So basically this feature is not available for your app itself.

To me the question is: what is the real intention of your initial question. I feel it is more like a back to Home menu jump, regardless from where. This should work with a normal jump by using https://github.com/olikraus/u8g2/blob/a5f674fedd5e75e71389e6ad2531363b654bdf76/csrc/mui.h#L226 and increasing the above mentioned cache.

microbmen commented 3 months ago

The intension is this, suppose I traverse from MUI_FORM(1) to MUI_FORM(3), to MUI_FORM(7),
and MUI_FORM(1) is a list of 4 submenus, I select the 2nd item which takes me to MUI_FORM(3), MUI_FORM(3) has 4 item list. I select the 4th item, which takes me to MUI_FORM(7). I want the back button on MUI_FORM(7) to take me to MUI_FORM(3), and position is the 4th item. issuing 'back' again and I would be on MUI_FORM(1) on the 2nd item.

I've accomplished this by using variable for every single form menu, and when the back button is tapped the FORM and Initial position is set depending on that variable. Its working, but would be nicer if 'back' was available.

qianfan-Zhao commented 3 months ago

@olikraus @microbmen Hi, new version based on MUI_MENU_CACHE_CNT feature is pushed on #2479, please review again.

rproesel commented 3 months ago

I was also looking for a back button, so I tried the code you posted. It seems to work and does just what I needed. Thanks!