Refactoring build scripts for macOS and windows

olilarkin / ort-builder

ONNX Runtime static library builder

MIT License

48 stars 13 forks source link

Closed tiborvass closed 1 year ago

tiborvass commented 1 year ago

Apart from refactoring here is a couple of changes I'm suggesting:

build-win.bat only builds MinSizeRel but script has been parameterized for easy change
build-mac.sh and build-win.bat accept an onnx config as their first argument if the user does not want the default.
do not hard code Visual Studio version numbers, use the latest installed instead

Please let me know what you think, thanks!

olilarkin commented 1 year ago

This looks like a good improvement. I'll check it out more this weekend. Thanks!