olimorris / neotest-rspec

๐Ÿงช Neotest adapter for RSpec. Works in Docker containers too
MIT License
88 stars 25 forks source link

"Trouble" quicklist plugin showing duplicate failures #10

Closed prdanelli closed 2 years ago

prdanelli commented 2 years ago

Hello,

I'm not sure if this is an issue, one that related to this adapter or Neotest, but I thought I would mention it anyway.

When I run a set of specs, I see a non-uniq list of failures being populated into the LSP Diagnostics quicklist LSP plugin Trouble.

image

I've run these specs a few times now (as I am not managing to fix the issue ๐Ÿค“), but apart from that I can't think of a reason they would show in there like this.

olimorris commented 2 years ago

I noticed this the other day and a nice diagnostic = false in the config fixes the issue ๐Ÿ˜† .

Seriously though I'm not sure what is causing the duplicates. If you restart Neovim and run lua require("neotest").run.run() next to that troublesome test can you confirm how many items get sent to Trouble?

prdanelli commented 2 years ago

I can confirm that after the restart, with Trouble empty before, running the failing test fills it with multiple duplicates - 92 of them. And diagnostic = false prevents them from showing.

Before... image

After... image

olimorris commented 2 years ago

Hahaha wow. 92!

I'll have to do some digging into how neotest handles this in order to solve!

prdanelli commented 2 years ago

I too was surprised by the shear volume of messages :D

olimorris commented 2 years ago

Figured out the error. Because I'm passing the whole backtrace to the error block!

olimorris commented 2 years ago

That's more like it:

Screen Shot 2022-06-16 at 20 53 45@2x

I'll format the output soon

olimorris commented 2 years ago

Hopefully should be more readable:

Screen Shot 2022-06-16 at 21 05 08@2x
prdanelli commented 2 years ago

OMG your bottom bar is beautiful! I wanted to ask you how you got the line-height on it, as I couldn't see anything in your dotfiles that worked for me?

image
olimorris commented 2 years ago

It should be this line in my kitty.conf. It's only taken me about 1,000 hours to get it just how I like it ๐Ÿ˜† .

prdanelli commented 2 years ago

Thank you! I tried it out and it ...

image

I might have to adjust it slowly over time to get used to it :D

olimorris commented 2 years ago

It's getting closer to a banana than an apple ๐Ÿ˜† . Mine looks the same unfortunately.

I'm edging you in the brew packages stakes though:

Screen Shot 2022-06-16 at 22 04 50@2x