olimorris / neotest-rspec

🧪 Neotest adapter for RSpec. Works in Docker containers too

MIT License

88 stars 25 forks source link

Add more specs #18

Closed alxekb closed 2 years ago

alxekb commented 2 years ago

@olimorris thanks for your contributions. I tried to make it work on my project but I failed 😞 I spent a day trying to find the issue but didn't managed. So I'm going to provide you examples, hope this helps 🙂

There is an issue running :lua require('neotest').run.run() from line spec/nested/basic_spec.rb:17 test result doesn't match expected result

running :lua require('neotest').run.run(vim.fn.expand('%')) from spec/class_method_spec.rb won't get expected result

olimorris commented 2 years ago

Hey @alxekb. Firstly, thanks so much for the pull request. Appreciate you taking the time to do it. Really, really helpful to have that alongside an issue.

I think we've actually just addressed all of these issues in this commit. I've run your tests and they all work as expected. Can you give it a try and feedback?

alxekb commented 2 years ago

@olimorris Yaay it works! 😃

Thanks a lot! It's a pleasure to use it!

🔥 🔥 🔥

olimorris commented 2 years ago

Woooop 🎉 . Great to hear. I think the latest changes have made the adapter more robust as we're using file paths and line numbers. Should be pretty difficult to break it now 😄 .