olimorris / neotest-rspec

🧪 Neotest adapter for RSpec. Works in Docker containers too
MIT License
88 stars 25 forks source link

neotest-summary shows too much context #39

Closed hereGittyGitty closed 1 year ago

hereGittyGitty commented 1 year ago

Hi

since commit 9b0386c the neotest-summary is broken:

2023-03-24-180144_953x552_scrot

On 250b008 it looks normal:

2023-03-24-180249_954x547_scrot

thx

olimorris commented 1 year ago

Any chance of you being able to share an RSpec file that I can test?

hereGittyGitty commented 1 year ago

Sure... rspec_bowling.zip

olimorris commented 1 year ago

This looks like it's working as intended:

Screen Shot 2023-03-26 at 13 53 43@2x

Sure it gives a lot of context but tests are being executed properly and reporting the correct status.

hereGittyGitty commented 1 year ago

Hey @olimorris , thank you for looking into this.

Sure it gives a lot of context but tests are being executed properly and reporting the correct status.

Yes, the tests are executed properly and reporting the correct status, but the neotest-summary window doesn't stop with showing the examples as a "leaf" node. (the description of the it expression).

For example, using the commit 250b008, the neotest-summary window looks like this:

2023-03-26-154630_833x243_scrot

Here, the neotest-summary window correctly shows the description of the example as a leaf node.

Whereas, since commit 9b0386c, the neotest-summary window adds the complete example to the leaf-node.

2023-03-26-155000_956x448_scrot

I think this messes-up the neotest-summary window, especially when you have more than one example in an example-group.

I renamed the issue to a more appropriate name.

olimorris commented 1 year ago

Oooof. Good point. I know the TS query that causes this so will fix later.

olimorris commented 1 year ago

@hereGittyGitty this should now be fixed. Let me know if not.