feat: Add support for running rspec in a docker container.

olimorris / neotest-rspec

🧪 Neotest adapter for RSpec. Works in Docker containers too

MIT License

88 stars 25 forks source link

feat: Add support for running rspec in a docker container. #52

Closed ramblex closed 1 year ago

ramblex commented 1 year ago

Hello, this PR adds support for running rspec in a docker container by adding a couple of new config options:

transform_spec_path allows the spec path to be modified before being passed to rspec. When running in a docker container a relative path needs to be used instead of an absolute path.
results_path allows the results file to be modified so that it's available to both the docker container and host.

olimorris commented 1 year ago

Firstly, thank you for the PR. This is such a huge ask for the community and will be hugely helpful.

I've cloned this locally and ran make test and all of the tests have failed. Can you try running this locally and seeing if you get the same?

ramblex commented 1 year ago

Ah yes, sorry! Missed fixing the default results_path function when I was tidying things up. The tests are passing for me now.

mmirus commented 1 year ago

Nice work, @ramblex! Thanks for implementing this. Tried it out for one project and was able to replace the shell script workaround I was previously using.