search

olimorris / onedarkpro.nvim

🎨 Atom's iconic One Dark theme. Cacheable, fully customisable, Tree-sitter and LSP semantic token support. Comes with variants
MIT License
765 stars 38 forks source link

README needs update after removing lualine support #149

Closed VPavliashvili closed 1 year ago

VPavliashvili commented 1 year ago

Issue/Question/Enhancement

After this commit cf4d0be17db8fe1bcd062f5a65fb857225ba3fa3 lualine support has dropped, so README section Extras needs update accordingly.

olimorris commented 1 year ago

Not at all:

Screen Shot 2023-01-08 at 17 26 36@2x

Not sure what you're seeing but the commit simply removed the reference to the onedarkpro colorscheme which doesn't technically exist anymore.

VPavliashvili commented 1 year ago

I don't understand exactly what happened, just when I sync packer several hours ago, lualine stopped working because I had set theme to onedarkpro. After than I came to read readme and found this line from extras section

Lualine The theme has Lualine support out of the box for all of its themes. This can be found in the Lualine folder.

but if you click Lualine folder it returns 404. So I thought that you removed lualine support but kept redundant instruction in readme, sorry if I misunderstood the changes

olimorris commented 1 year ago

I don't understand exactly what happened, just when I sync packer several hours ago, lualine stopped working because I had set theme to onedarkpro. After than I came to read readme and found this line from extras section

The onedarkpro theme has been deprecated for a while now. Please use onedark, onelight or equivalent.

The theme has Lualine support out of the box for all of its themes. This can be found in the Lualine folder.

Looks like the link is out of date so thanks.