olimorris / tmux-pomodoro-plus

🍅 Incorporate the Pomodoro technique into your tmux workflow
MIT License
274 stars 23 forks source link

Add seconds along with minutes MM:SS format #13

Closed PezCoder closed 1 year ago

PezCoder commented 1 year ago

Hey! First of all, thank you for this, I've been looking for something like this plugin for a long & luckily stumbled upon this.

I wanted to know if it's possible to show not only the minutes but also the seconds, like in any typical pomodoro plugins (ex: https://flowapp.info/)

I would be happy to raise a PR for the same if you agree.

PS: On a separate note, I absolutely loved your tmux theme, & that's something I ended up copying with little modifications. I would highly recommend making it available through TPM, as the ones which are available are not that great. :)

PezCoder commented 1 year ago

I was checking the code & from the implementation perspective I wanted to know the following:

olimorris commented 1 year ago

Thanks very much. The tmux theme is based around the colors from my Neovim theme.

Also, absolutely open for a PR on this, providing that we give the users an option to enable it. My other concern, as you rightly questioned, is that the display is dictated by status-interval. This is where my knowledge of much of tmux's functionality is exposed as I'm not sure if there is a nicer way to get around this other than tmux set status-interval 1.

PezCoder commented 1 year ago

Thank you for all the guidance on this, I would say this is my first legit open source contribution lol

olimorris commented 1 year ago

That's great to hear and what an awesome contribution it was. Thank you