olimorris / tmux-pomodoro-plus

🍅 Incorporate the Pomodoro technique into your tmux workflow
MIT License
311 stars 26 forks source link

feat: add auto_start_break feature #24

Closed matteodiga closed 1 year ago

matteodiga commented 1 year ago

Inspired by a feature that another pomodoro app provides (https://pomofocus.io/)

Explanatory commit message:

Add auto_start_break feature that prevent break time to start automatically so,
after the pomodoro focus time end, user has to manually start the break.
This way user can choose when start the break time based on what it's doing.

The flow is:

- start pomodoro focus time     - user action (<tmux-prefix> p)
- focus time...
- end focus time, ask for a break
- wait for a break...
- start pomodoro break time     - user action(<tmux-prefix> p)
- break time...
- end pomodoro

The auto_start_break feature is disable by default.

I would like to enable by default this feature because I found very useful end things I'm working on and then start the break, but I'll let you choose this @olimorris.

olimorris commented 1 year ago
Screen Shot 2023-07-31 at 11 46 00@2x

My knowledge of anything complex in Git isn't great. Is there anything in your repo that's stopping me making changes?

matteodiga commented 1 year ago

How do you fetch my code from this PR? Maybe you can try with a rebase starting from my code/branch (I have never receive a PR on github, I'm not sure how it works). This way remote code (PR code) and your local code will be sync and you will not receive this error.

I don't think it's a problem from my repo because:

Try with a rebase locally in your repo, if it doesn't work I can try to delete my fork, re-fork, push changes and reopen PR. Let me know :)

olimorris commented 1 year ago

I clone it locally like so:

Screen Shot 2023-07-31 at 13 24 34@2x

Can't figure out why it's not working so I'll merge later and make some tweaks after.

This shouldn't distract from the fact this is an awesome PR. I'm going to turn it off by default, simply because I hate to force a change of workflow onto a user. If you can think of an elegant way of letting people know about new features, I'm all ears.

I shall be using this feature myself, so thank you

matteodiga commented 1 year ago

Very strange, I tried to checkout the PR as you're doing but my git status is clean and without any conflicts, did you try to rebase after pr checkout?. I suggest you to try to delete and clone again the repo, maybe your local upstream/repo is messed up or there are some other git mysteries.

BTW, I appreciate your comment. To point out the new feature, but more in general any new future features, we (you) can think about release mechanism as github suggest via "Release" without any asset but just with images and or text description about new things. It could be possible also to edit README to expose main workflow in a "Example" chapter, using different feature like this one, auto repeat etc. One way does not exclude the other one :)

Useful link about git "Release" in case you are not aware of

olimorris commented 1 year ago

Really good point about releases. Something I do some of my other open source projects.

I wish TPM had a nice way of notifying users of new and breaking features.

Thanks again for your efforts on this. Great feature to have in the plugin.

matteodiga commented 1 year ago

I'm open for helping you about release implementation if you need. Let me know. P.S. thank you for this loveable tmux plugin 😊