search

olimorris / tmux-pomodoro-plus

🍅 Incorporate the Pomodoro technique into your tmux workflow
MIT License
327 stars 27 forks source link

Sound broken on macOS #5

Closed mskelton closed 2 years ago

mskelton commented 2 years ago

This seems to have broken sound on macOS due to these lines.

https://github.com/olimorris/tmux-pomodoro-plus/pull/2/files#diff-49376947ccc1be4101aa3ff278c29ca8d4e0809d5cc6e1e9102daf15b8e8f4bdR80-R85

It checks if the sound is 'on' but then uses that as the sounds name but on is not a sound name.

Originally posted by @mskelton in https://github.com/olimorris/tmux-pomodoro-plus/issues/2#issuecomment-1189067778

olimorris commented 2 years ago

Thanks for flagging. Can you check if the latest commit has fixed it?

mskelton commented 2 years ago

Works great, thanks for the fast response!

uzza1hossain commented 2 years ago

Notification and sound did not work on Linux!

olimorris commented 2 years ago

@uzza1hossain can you raise a seperate issue for this and share your config?