search

olin-build / ABE

Amorphous Blob of Events
https://abe.olin.build/
GNU Affero General Public License v3.0
7 stars 1 forks source link

flake8 fixes #197

Closed osteele closed 6 years ago

osteele commented 6 years ago

Fix remaining flake8 errors, with a few cheats, marked by FIXME.

Travis now fails flake8 errors.

This gets most of the way towards #171. Remaining work is marked by TODO (in setup.cfg) and FIXME (in ics_helpers.py).

codecov[bot] commented 6 years ago

Codecov Report

Merging #197 into dev will decrease coverage by 0.14%. The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #197      +/-   ##
==========================================
- Coverage   59.75%   59.61%   -0.15%     
==========================================
  Files          21       21              
  Lines        1148     1144       -4     
==========================================
- Hits          686      682       -4     
  Misses        462      462
Impacted Files Coverage Δ
abe/helper_functions/converting_helpers.py 88.09% <ø> (-0.28%) :arrow_down:
abe/helper_functions/query_helpers.py 79.59% <ø> (-0.41%) :arrow_down:
abe/helper_functions/ics_helpers.py 33.67% <0%> (-0.18%) :arrow_down:
abe/helper_functions/email_helpers.py 86.06% <0%> (-0.12%) :arrow_down:
abe/helper_functions/sub_event_helpers.py 40% <0%> (+0.36%) :arrow_up:
abe/database.py 85.71% <100%> (ø) :arrow_up:
abe/helper_functions/recurring_helpers.py 81.81% <100%> (-0.41%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 84e558e...2e117b6. Read the comment docs.