search

oliora / ppconsul

C++ client for Consul (http://consul.io)
Boost Software License 1.0
152 stars 57 forks source link

Fix base64 encoding of long strings #43

Closed shdown closed 4 years ago

shdown commented 4 years ago

ppconsul::helpers::encodeBase64() did not account for the fact that base64_encode_block() adds line breaks every 72 symbols or so. Let's just remove this "feature" from base64_encode_block().

oliora commented 4 years ago

Please add unit test(s) for base64 encoding of long strings under https://github.com/oliora/ppconsul/blob/master/tests/unittests/helpers.cpp

shdown commented 4 years ago

Done.

oliora commented 4 years ago

Thank you for the fix!