search

olirice / alembic_utils

An alembic/sqlalchemy extension for migrating sql views, functions, triggers, and policies
https://olirice.github.io/alembic_utils
MIT License
211 stars 43 forks source link

Pin parse version to >=1.8.4 #102

Closed dimitris-flyr closed 1 year ago

dimitris-flyr commented 1 year ago

parse 1.8.4 is the first version of the case_sensitive argument introduced. We had this exact issue where this code block failed because the installed parse version was 1.6.x https://github.com/olirice/alembic_utils/blob/master/src/alembic_utils/pg_function.py#L43

https://pypi.org/project/parse/1.8.4/ >>> parse('SPAM', 'spam', case_sensitive=True) is None

codecov-commenter commented 1 year ago

Codecov Report

Merging #102 (8eb7730) into master (79bd169) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          18       18           
  Lines         863      863           
=======================================
  Hits          862      862           
  Misses          1        1
Flag Coverage Δ
unittests 99.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

olirice commented 1 year ago

Thanks for the PR. This change is available on pypi in version 0.8.0