olirice / alembic_utils

An alembic/sqlalchemy extension for migrating sql views, functions, triggers, and policies
MIT License
193 stars 42 forks source link

modified entity sorting function #122

Closed tauseef13bok closed 7 months ago

olirice commented 7 months ago

Thanks for opening a PR, I can see you put thought into this solution but unfortunately I don't think its a good fit for upstreaming.

Choosing not to emulate create or replace behavior with drop and create was an intentional decision that I'm not comfortable changing

The dependency resolution change itself is interesting but seems to fail on a few of the test cases and the impact on runtime is a few 100x slower than the existing implementation and was prohibitively slow on a larger test schema that I use for regression testing

In this case I think your best bet is to use it as a fork