Closed ddemidov closed 2 years ago
Merging #69 (b87fc8a) into master (683a447) will decrease coverage by
0.11%
. The diff coverage is80.00%
.
@@ Coverage Diff @@
## master #69 +/- ##
===========================================
- Coverage 100.00% 99.88% -0.12%
===========================================
Files 18 18
Lines 840 842 +2
===========================================
+ Hits 840 841 +1
- Misses 0 1 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 99.88% <80.00%> (-0.12%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/alembic_utils/pg_function.py | 98.33% <80.00%> (-1.67%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 683a447...b87fc8a. Read the comment docs.
thanks for the PR
officially alembic_utils
doesn't support non-language sql
functions. The plpgsql line was a forced measure to get something working at the office but it is not public/documented.
Since this is a small update, if it were covered by an integration test, I'd merge it and leave the behavior undocumented but that won't be possible without using a custom docker image b/c the base postgres images don't have plpythonu installed.
In this case it might be easier for you to subclass PGFunction
and override the __init__
in your application code.
Fair enough. Thank you for the subclassing tip, I had not thought of that!
This disables escaping of ':' symbols for plpython functions. Without this, the following definition
gets converted to
which results in