olirice / alembic_utils

An alembic/sqlalchemy extension for migrating sql views, functions, triggers, and policies
https://olirice.github.io/alembic_utils
MIT License
211 stars 43 forks source link

Static dispatch of alembic comparators #84

Closed DanCardin closed 2 years ago

DanCardin commented 2 years ago

Fixes https://github.com/olirice/alembic_utils/issues/80

So there are a few things i'll point out:

DanCardin commented 2 years ago

the net -1 line of code cov looks like is because there's no existing coverage of exclude_schemas which your comments imply is deprecated anyway. I can perhaps add a test for it, if you think that's important

olirice commented 2 years ago

the net -1 line of code cov looks like is because there's no existing coverage of exclude_schemas which your comments imply is deprecated anyway. I can perhaps add a test for it, if you think that's important

Yeah I've been meaning to remove it. No worries about the coverage line