olirice / alembic_utils

An alembic/sqlalchemy extension for migrating sql views, functions, triggers, and policies
MIT License
193 stars 42 forks source link

Remove extras requirement for sqlalchemy-stubs #99

Closed jochs closed 1 year ago

jochs commented 1 year ago

SqlAlchemy 1.4 uses sqlalchemy2-stubs as the package it ships stubs in -- alembic_utils requiring the legacy sqlalchemy-stubs package causes issues with mypy plugin integration. I'm submitting a PR to remove the requirement rather than upgrade because it seems like convention is to let the consumer decide which to install. Happy to swap the package to sqlalchemy2-stubs instead, though.

Let me know if this makes sense! Appreciate all the work you've put in to this project.