search

olistic / warriorjs

🏰 An exciting game of programming and Artificial Intelligence
https://warriorjs.com
MIT License
9.43k stars 490 forks source link

Warrior should be upset when losing points #104

Closed olistic closed 6 years ago

olistic commented 6 years ago

Currently, the warrior is proud of earning points, but he or she should also be upset for losing points.

skywalker212 commented 6 years ago

can i work on this? I have to modify the losePoints method, right?

olistic commented 6 years ago

Hey @skywalker212, of course! Units can earn or lose points, but they do so silently. In case of the warrior, we want to log that using .say(). We are already doing that for earnPoints here. Now we need to do the same for losePoints (override its implementation in Warrior).

skywalker212 commented 6 years ago

okay!

skywalker212 commented 6 years ago

https://github.com/skywalker212/warriorjs/commit/f6fcd253d3cdf8d35353b90577a437501228e696 @olistic please review.

olistic commented 6 years ago

@skywalker212 Looks good, you should open a PR for review though!

skywalker212 commented 6 years ago

@olistic okay!