Closed skywalker212 closed 6 years ago
Merging #107 into master will increase coverage by
0.02%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 90.84% 90.87% +0.02%
==========================================
Files 80 80
Lines 1016 1019 +3
Branches 158 158
==========================================
+ Hits 923 926 +3
Misses 77 77
Partials 16 16
Impacted Files | Coverage Δ | |
---|---|---|
packages/warriorjs-core/src/Warrior.js | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 42ad255...d872b7d. Read the comment docs.
@olistic ya sure, but I don't know how to add a unit test, can you tell me how to add one?
@skywalker212 Sure. In this particular case, it's super easy. Just look at the earning points test in Warrior.test.js
and base yours on that one!
@olistic I have added the unit test, please review.
@olistic I have made the changes, please review.
@olistic Thanks for guiding through problems!
Closes #104