olistic / warriorjs

🏰 An exciting game of programming and Artificial Intelligence
https://warriorjs.com
MIT License
9.43k stars 490 forks source link

Fixed diamond symbol on windows CMD #121

Closed glneto closed 6 years ago

glneto commented 6 years ago

Hello!

This change should fix the diamond symbol on Windows' CMD. I used the is-windows util to check the user env and in case that returns true, I use the Black Diamond Suit (as suggested on the issue), otherwise I keep the black medium diamond symbol.

I hope that helps.

Fixes #112

codecov-io commented 6 years ago

Codecov Report

Merging #121 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files          80       80           
  Lines        1019     1019           
  Branches      158      158           
=======================================
  Hits          926      926           
  Misses         77       77           
  Partials       16       16
Impacted Files Coverage Δ
...ackages/warriorjs-cli/src/ui/printWarriorStatus.js 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1872e0c...530e2a8. Read the comment docs.

glneto commented 6 years ago

@olistic Alright! I didn't see the is-windows package wasn't being used. Should be good now :)