checks if unit is alive after status effects.

[msaikaushik]

modified the performTurn so that effects are taken into consideration.

[msaikaushik]

hi @olistic , may i know what was wrong in the way i PR'd. is it about the tests or is it about how i did the PR? thank you.

[olistic]

Hello @IceDune. It was not about "how" you opened the PR, it's about the tests (more specifically linting and formatting issues). Note that CI is failing, if you click on details you will see why. But more importantly, make sure you run the tests locally before submitting code for review. Please read and make sure you are following the CONTRIBUTING guidelines. Thanks.

[msaikaushik]

@olistic , please let me know if there is any change that needs to be done in the PR. thanks a lot

[olistic]

Hello @IceDune, sorry for the big delay. I'll be a bit busy for a couple more days, and then I'll review this.

[codecov[bot]]

Codecov Report

Merging #230 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files          92       92           
  Lines        1091     1091           
  Branches      165      165           
=======================================
  Hits         1008     1008           
  Misses         68       68           
  Partials       15       15

Impacted Files	Coverage Δ
packages/warriorjs-core/src/Unit.js	100% <100%> (ø)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97bac9f...70be79d. Read the comment docs.

[msaikaushik]

@olistic , i removed the isAlive check at the beginning of performTurn which might not be required. please let me know of any more changes.