search

olive-editor / olive

Free open-source non-linear video editor
https://olivevideoeditor.org/
GNU General Public License v3.0
8.19k stars 555 forks source link

Fresh windows install fresh olive install reveals Adware.FPL.Gen.vl. Please remove from windows package. :-( #1447

Closed digc16 closed 3 years ago

digc16 commented 3 years ago

Commit Hash

Platform

Summary

Additional Information / Output

digc16 commented 3 years ago

Fresh windows install fresh olive install reveals Adware.FPL.Gen.vl. Please remove from windows package. :-(

digc16 commented 3 years ago

crashpad_handler.exe maindump_stackwalk.exe olive_crash_handler.exe olive_editor.exe uninstall.exe

then something like 92 dll's as a part of Adware.FPL.Gen.vl

Gridinsoft Anti-Malware scanner was used. There was no incentive to report this other than I love your software and would like it to not be compromised. Best of luck. Time to uninstall. Thank you.

ThomasWilshaw commented 3 years ago

Can I just check, did this come directly from the Olive website?

elsandosgrande commented 3 years ago

@digc16 Since VirusTotal had no complaints whatsoever, I'm willing to bet that that antivirus is not worth any money.

Simran-B commented 3 years ago

Detection is often based on heuristics, and especially something like Crashpad has the potential of being detected as malicious because it ticks several boxes. It's also very common for Windows SmartScreen to block nightly builds, simply because they contain unsigned and uncommon binaries. There is no adware in official Olive builds however. Don't trust other sources, someone might have tampered with the executables.

elsandosgrande commented 3 years ago

@Simran-B Windows SmartScreen even‽ I can't tell if that's because it's very sensitive, or because it isn't as high quality as antivirus software from dedicated companies.

@digc16 Where did you acquire the build which was detected as adware?

itsmattkc commented 3 years ago

@elsandosgrande Windows SmartScreen isn't doing anything "smart" there, if an executable is unsigned and isn't in their list of "frequently downloaded executables", it blocks it by default (macOS does the same thing). Definitely should look into getting our executables signed by the time we have stable releases (probably not worth it for nightlies).

elsandosgrande commented 3 years ago

Oh. I know even less about Windows than I thought then :sweat_smile:.