olive-editor / olive

Free open-source non-linear video editor
https://olivevideoeditor.org/
GNU General Public License v3.0
8.16k stars 554 forks source link

Fix Wayland Transparency #2226

Closed Quackdoc closed 1 year ago

Quackdoc commented 1 year ago

Partially addresses #1630

it turns out that the alpha we set is actually passed onto the compositor, so by setting 0.0 alpha, we were inadvertently telling the compositor to make the window transparent.

Quackdoc commented 1 year ago

turns out this might be a bit more tricky, the implementation here is wrong, but even with doing it in viewerdisplay so it doesn't mess up exports, changing the opacity will change the translucency of the surface, so either a subsurface is needed, or on opaque bottom texture for the viewer

itsmattkc commented 1 year ago

I recently started playing around with Wayland and resolved a number of issues including this one. Thanks for finding the source of the transparency issue, but this should be resolved now.