olive-groves / butterfly_registrator

Desktop app for aligning images using draggable control points (manual image registration). Batch mode to process multiple images such as XRF and RIS element maps from painting analyses. Converts and merges alphascale images. Installs as a Windows executable and runs directly on Python. Very open source.
https://olive-groves.github.io/butterfly_registrator/
Other
4 stars 1 forks source link

[Bug] Butterfly registrator crashes when loading second image to register #17

Closed MaryaAlbrecht closed 3 months ago

MaryaAlbrecht commented 4 months ago

Is there an existing issue for this?

Current behavior

I've installed the latest version of butterfly registrator on my pc (Windows 11). The installation works fine. After opening registrator it let's me load a reference image (the first image) but when loading the second image (the image to be registered) the program crashes. This happens for all images I've tried so far. Is this a known issue? I've worked with registrator before (on different PC's) and it worked really well.

Expected behavior

I expected to load two images to register without a problem, as I have done in the past.

Steps to reproduce

No response

Anything else?

No response

larsmaxfield commented 4 months ago

@MaryaAlbrecht it's not a known issue — thanks for reporting.

Does it crash both when loading via drag-and-drop as well as via the open dialog ('Select' button)?

And can you confirm whether the same images which crash that installation don't crash the other installations?

I don't (yet) have a Windows 11 machine to test whether it's a Windows 11 issue. In the meantime I'll try reinstalling on Windows 10.

larsmaxfield commented 4 months ago

@MaryaAlbrecht in addition to the above items, can you confirm if it also crashes when adding images in the Alphascale tab? Here's an example grayscale map you can try.

I checked the latest installer for Registrator and it works on two different Windows 10 machines.

I plan to make a debugging executable for you to test soon so we can solve this.

MaryaAlbrecht commented 4 months ago

Hi Lars,

Thanks for your quick reply. It crashes both when opening the images by dragging and via the open dialog. I've tested the same images on a different installation (other laptop, windows 10) and there it works fine without crashing. The grayscale map you provided also opens without crashing on my laptop (windows 11)

larsmaxfield commented 4 months ago

Hi Marya, thanks for confirming.

If possible, can you try running this debug executable (316 MB ZIP) in the command prompt on your Windows 11 laptop and letting me know if an error message appears in the command prompt?

Here are steps to get that running:

1. Copy the path to the unzipped executable

2. Run the executable via the command prompt

3. Wait for the Registrator to open This can take up to 60 seconds because the executable has everything packaged into one file and needs to temporarily unpack everything before it actually runs.

4. Try to crash the Registrator by adding images

5. If/when it crashes, make a screenshot of the error(s) in the command prompt

image

MaryaAlbrecht commented 3 months ago

Hi Lars, I downloaded the executable and it crashed when loading the images. This is wat the command prompt said:

Schermafbeelding 2024-06-10 211626_butterfly bug
larsmaxfield commented 3 months ago

Thanks for checking.

Can you try copying the image to a different folder and then adding the image into the Registrator from there? For example, copy it outside the Foto's Ren |® 2024 folder to C:/Users/Marya/Documents/, or simply copy it to your desktop.

I think the issue is caused by the special character(s) in the folder name Foto's Ren |® 2024 where your image is stored:

image

It seems the image processing library in Registrator can't directly handle files whose fullpaths (directories) contain special characters.*

*References: https://stackoverflow.com/questions/72022176/warning-cant-open-read-file-check-file-path-integrity https://stackoverflow.com/questions/44330084/opencv-imwrite-doesnt-work-because-of-special-character-in-file-path

MaryaAlbrecht commented 3 months ago

It worked! I copied the files to the desktop and everything went smoothly, then changed all the folder names and it also works smoothly. Thanks so much for your help!

larsmaxfield commented 3 months ago

Great to hear! Happy to help.