oliver-batchelor / multical

Multi-camera calibration using one or more calibration patterns
Other
362 stars 67 forks source link

Could you expand the calibrate targets for checkerboard? #13

Open uestchang opened 2 years ago

uestchang commented 2 years ago
oliver-batchelor commented 2 years ago

Hi @uestchang,

You have caught me out there, I intend to support plain checkerboard and indeed it is not that much code to do so - I just haven't added it yet. The help message is indeed misleading for the moment!

Sorry about that - it is another for my TODO list, though obviously I welcome anyone who wants checkerboards to have a go at adding it :)

Oliver

On Fri, Oct 8, 2021 at 9:30 PM uestchang @.***> wrote:

-

Question: Thanks for your wonderful work, I have seen that Calibration targets supported are currently, charuco boards and aprilgrid boards (as used by Kalibr). However, I only have checkerboard. If I want to use checkerboard to calibrate my camera, what function should I add for getting the correct returned Value of instantiate_board(config)?

Error: unknown board type: checkerboard, options are (charuco | aprilgrid | checkerboard)" File "/home/mbh/multical-master/multical/board/init.py", line 73 def instantiate_board(config): if config.type == "charuco": schema = OmegaConf.structured(CharucoConfig) return CharucoBoard(aruco_params=aruco_params, merge_schema(config, schema)) elif config.type == "aprilgrid": schema = OmegaConf.structured(AprilConfig) return AprilGrid(merge_schema(config, schema)) else: assert False, f"unknown board type: {config.type}, options are (charuco | aprilgrid | checkerboard)"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/saulzar/multical/issues/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAITRZLOQ5A4RXNXPGQXLNTUF2T2FANCNFSM5FTCF2RA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

uestchang commented 2 years ago

@saulzar Thanks for your replying :) I am really looking forward to your further work for supporting checkerboard. Because I have no idea how to do it. Hope the results will come out soon :+1: