search

oliver-butterley / lean-update

The action attempts to update Lean and Mathlib. If an update is available then the updated version is tested. This allows for automatic committing of the updated project, opening PRs or opening issues.
MIT License
6 stars 2 forks source link

bug: update the way to get latest release #26

Closed Seasawher closed 2 months ago

Seasawher commented 4 months ago

In this workflow, it downloads v4.9.1 as the latest release.

see https://github.com/lean-ja/lean-by-example/actions/runs/9883761323/job/27299040801#step:3:1

but actually v4.10.0-rc2 is the latest. This is a bug of the way to get latest release.

important note: this issue make the workflow fail

oliver-butterley commented 4 months ago

This behaviour is because gh release list --repo leanprover/lean4 believes that v4.9.1 is the latest release:

image

In sense it is correct! As far as I can see, this is the first time in the release history of Lean 4 that the current strategy of lean-update fails. Not clear the best strategy to extract the wanted release from gh releases list.

Seasawher commented 4 months ago

If v4.9.2 or newer version come, I will think this issue seriously. I don't came up with any easy way to fix this.