search

oliver-giersch / tagptr

Marked raw and atomic pointers for concurrent programming
Other
3 stars 1 forks source link

Full Apache license text is needed. #2

Open pemensik opened 2 days ago

pemensik commented 2 days ago

Apache license file contains just short notice to be used in source files. Not a full license text, which it should.

I think it should be replaced with file obtained from URL: https://www.apache.org/licenses/LICENSE-2.0.txt

This was discovered as part of fedora package review: https://bugzilla.redhat.com/show_bug.cgi?id=2302630#c3

pemensik commented 2 days ago

Also license = "MIT/Apache-2.0" in Cargo.toml should be changed either to license = "MIT OR Apache-2.0" or license = "MIT AND Apache-2.0". I am not sure what exactly is meant by current statement written in README.md.

More is explained at: https://spdx.github.io/spdx-spec/v2.3/SPDX-license-expressions/#d4-composite-license-expressions

Ideally something like // SPDX-License-Identifier: MIT AND Apache-2.0 should be also part of non-trivial files of code. Depends on which is correct.

decathorpe commented 1 day ago

"MIT/Apache-2.0" is the deprecated form of MIT OR Apache-2.0, for the record. It's been dropped since at least v2.2.2 of the SPDX specification: https://spdx.github.io/spdx-spec/v2.2.2/SPDX-license-expressions/