search

oliver-giersch / tagptr

Marked raw and atomic pointers for concurrent programming
Other
3 stars 1 forks source link

Replace Apache license with full text of license #3

Open pemensik opened 2 days ago

pemensik commented 2 days ago

What were inside before were just a boilerplate, which should be included in source files. But at least Fedora Packaging Guidelines require full text of license to be distributed in the source archive. Not just reference to the used license on the Internet.

Fixes #2.

pemensik commented 2 days ago

What I am unsure about is how to interpret license in Cargo.toml. It says it should use SPDX format at https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields.

I do not think current MIT/Apache-2.0 is valid format. I assume it should be MIT OR Apache-2.0, but maybe it is MIT AND Apache-2.0 instead. It should be your decision to make, what exactly is meant by that. If it were mean as I can choose which one, OR would be correct. If both apply to all files, it should be clearly (and formally) specified.

https://spdx.github.io/spdx-spec/v2.3/SPDX-license-expressions/

If some files originate from work licensed under Apache-2.0, other from MIT project, it should be AND. Ideally each file should specify short SPDX indentifier, to make it clear what parts are covered by which license.