oliver / gedit-file-search

Gedit plugin to search a text in all files in a directory
https://oliver.github.io/gedit-file-search/
43 stars 11 forks source link

Find in currently selected directory in the file browser side pane #1

Open senotrusov opened 15 years ago

senotrusov commented 15 years ago

It would be nice if "Search in" field will be filled with currently selected directory in the file browser side pane.

Also, context menu for filebrowser directories may have a link to you plugin window, say "Search in this folder".

oliver commented 15 years ago

It would be nice if "Search in" field will be filled with currently selected directory in the file browser side pane.

That's tricky, from a user interface point-of-view... Currently, the dialog will try to use the same directory as in the last search. If it instead uses the currently-selected directory, it might surprise users that browsing in the file pane influences the values in the search dialog.

Some alternative ideas:

Also, context menu for filebrowser directories may have a link to you plugin window, say "Search in this folder".

That's a good idea, and probably quite easy to implement. It might also make the other issue a bit less important.

But currently I don't have much time for this, and my local working copy is in the middle of some large rewrites; so can't promise any fix soon.

oliver commented 13 years ago

In the latest version in Git there is now a "Search files..." item in the File Browser context menu (it is still pretty much experimental, though). This should cover the second part of this issue.

odigity commented 5 years ago

In the latest version in Git there is now a "Search files..." item in the File Browser context menu (it is still pretty much experimental, though). This should cover the second part of this issue.

It doesn't seem to work.

When I click on ⋮, then click on "Search files...", it pops up the search dialog box. However, when I right-click on a folder in the File Browser, then click on "Search files...", nothing happens.

PS - Happy one year anniversary, issue #1.

oliver commented 5 years ago

@odigity: Which Gedit version are you using?

I just tried this with Gedit 3.18.1 and 3.28.1, and it worked fine. But new Gedit versions sometimes break plugins.

odigity commented 5 years ago

3.32.0 on Pop!_OS 19.04 (aka Ubuntu 19.04)

oliver commented 5 years ago

Well, I don't have Ubuntu 19.04 available right now, so can't test it.

But I'm not really using Gedit any more, so this project is pretty much unmaintained - sorry. Nowadays there's a Find in Files plugin bundled with Gedit though (you might have to install the gedit-plugins package for this).

odigity commented 5 years ago

Yeah, I tried it - it was awful. :)