oliver006 / redis_exporter

Prometheus Exporter for ValKey & Redis Metrics. Supports ValKey and Redis 2.x, 3.x, 4.x, 5.x, 6.x, and 7.x
https://github.com/oliver006/redis_exporter
MIT License
3.12k stars 876 forks source link

Docker push action #771

Closed trejjam closed 1 year ago

trejjam commented 1 year ago

Describe the problem Hello Oliver, From time to time I hit issue that the docker container is missing for a new release. I propose to add Github actions which will automatically build and push the docker image for a new release. I can prepare PR for the action, I will only need you to create a secret key for that action.

Additional context https://hub.docker.com/r/oliver006/redis_exporter/tags?page=1&name=v1.47 https://github.com/oliver006/redis_exporter/releases/tag/v1.47.0

oliver006 commented 1 year ago

I hear you. Unfortunately, one of the tests broke (because I didn't have a dependecy pinned) so the release failed. I'm looking into fixing this. I'd love to make the CI/CD process more robust but moving the release process to Github Actions is a significant amount of work which I don't have the time for right now. I know you offered help but there;'s also making sure that the manifests are created right, etc. I started some work on Github actions to at least run the tests there - if you want to piggy back on that just go ahead but right now I don't want to spend a ton of time on something that's working well (most of the time).

oliver006 commented 1 year ago

Released https://github.com/oliver006/redis_exporter/releases/tag/v1.47.0