oliver006 / redis_exporter

Prometheus Exporter for ValKey & Redis Metrics. Supports ValKey and Redis 2.x, 3.x, 4.x, 5.x, 6.x, and 7.x
https://github.com/oliver006/redis_exporter
MIT License
3.12k stars 876 forks source link

feat: add node role metric #819

Closed snoojen closed 1 year ago

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 165


Totals Coverage Status
Change from base Build 164: 0.02%
Covered Lines: 1947
Relevant Lines: 2104

💛 - Coveralls
oliver006 commented 1 year ago

instance_info already exports role - how is this different?

See here:

redis_instance_info{app="redis", instance="10.42.0.246:9121", job="kubernetes-pods", maxmemory_policy="noeviction", 
namespace="redis", os="Linux 5.4.0-153-generic x86_64", pod="redis-5d7898859b-6jnq9", 
pod_template_hash="5d7898859b", process_id="1", redis_build_id="3a1fe9d08e5ebeb", redis_mode="standalone", 
redis_version="6.2.12", role="master", run_id="9a291d29d3ceea449633316f29712616ecc11a07", tcp_port="6379"}
snoojen commented 1 year ago

Thanks for the response! That fits the need we have for now - I'll close the PR.