oliver006 / redis_exporter

Prometheus Exporter for ValKey & Redis Metrics. Supports ValKey and Redis 2.x, 3.x, 4.x, 5.x, 6.x, and 7.x
https://github.com/oliver006/redis_exporter
MIT License
3.03k stars 859 forks source link

Does Redis Exporter really need allkeys permission? #821

Closed kas-kad closed 11 months ago

kas-kad commented 11 months ago

Hello, reading the docs I have found one suspicious thing:

ACL SETUSER <<>> +client +ping +info +config|get +cluster|info +slowlog +latency +memory +select +get +scan +xinfo +type +pfcount +strlen +llen +scard +zcard +hlen +xlen +eval allkeys on > <<>>

Why does Redis Exporter need allkeys permission that allows accessing any possible key?

oliver006 commented 11 months ago

You should always adjust the permissions as needed / appropriate for your use case. If you want to export key values via metrics or use any of check-keys features then you'll need permissions accordingly.