I want to Add Basic authentication for accessing Exporter, Do you need this enhanced code?

oliver006 / redis_exporter

Prometheus Exporter for ValKey & Redis Metrics. Supports ValKey and Redis 2.x, 3.x, 4.x, 5.x, 6.x, and 7.x

https://github.com/oliver006/redis_exporter

MIT License

3.03k stars 859 forks source link

I want to Add Basic authentication for accessing Exporter, Do you need this enhanced code? #833

Closed AirTrioa closed 9 months ago

AirTrioa commented 9 months ago

Describe the problem

Due to special needs, our company needs to add basic auth for RedisExporter, but I found that the exporter itself does not support it, so I modified the source code based on the master branch.
Now I want to submit these enhanced codes to the community. Do you need them ?
If necessary, I can initiate a merge request ? code address

oliver006 commented 9 months ago

Thanks for opening this issue and asking about that feature. I'd prefer to keep redis_exporter minimal - if e.g. basic auth is needed then a simple Nginx sidecar can serve that need.

AirTrioa commented 9 months ago

Okay, in many cases, the 'single responsibility principle' is indeed necessary, so I will close this issue later.