Closed chetratep closed 8 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
exporter/redis.go | 3 | 7 | 42.86% | ||
<!-- | Total: | 3 | 7 | 42.86% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
exporter/exporter.go | 13 | 94.36% | ||
<!-- | Total: | 13 | --> |
Totals | |
---|---|
Change from base Build 196: | 0.02% |
Covered Lines: | 1946 |
Relevant Lines: | 2115 |
Thanks for the PR, I'll try to review it in the next few days!
I think this makes sense.
Can you please add a test to confirm the expected behavior is working ?
Sure, I'll find sometime later to do it.
Quick bump @chetratep
Thanks for adding the tests @chetratep !
This PR is to fix the bug when using password file with
isCluster
mode.This issue #835