oliver006 / redis_exporter

Prometheus Exporter for ValKey & Redis Metrics. Supports ValKey and Redis 2.x, 3.x, 4.x, 5.x, 6.x, and 7.x
https://github.com/oliver006/redis_exporter
MIT License
3.03k stars 859 forks source link

Fix cluster refresh failed when using pasword file with isCluster mode #836

Closed chetratep closed 8 months ago

chetratep commented 9 months ago

This PR is to fix the bug when using password file with isCluster mode.

This issue #835

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 210


Changes Missing Coverage Covered Lines Changed/Added Lines %
exporter/redis.go 3 7 42.86%
<!-- Total: 3 7 42.86% -->
Files with Coverage Reduction New Missed Lines %
exporter/exporter.go 13 94.36%
<!-- Total: 13 -->
Totals Coverage Status
Change from base Build 196: 0.02%
Covered Lines: 1946
Relevant Lines: 2115

💛 - Coveralls
oliver006 commented 9 months ago

Thanks for the PR, I'll try to review it in the next few days!

oliver006 commented 9 months ago

I think this makes sense.

Can you please add a test to confirm the expected behavior is working ?

chetratep commented 9 months ago

Sure, I'll find sometime later to do it.

oliver006 commented 8 months ago

Quick bump @chetratep

oliver006 commented 8 months ago

Thanks for adding the tests @chetratep !