oliver006 / redis_exporter

Prometheus Exporter for ValKey & Redis Metrics. Supports ValKey and Redis 2.x, 3.x, 4.x, 5.x, 6.x, and 7.x

https://github.com/oliver006/redis_exporter

MIT License

3.03k stars 859 forks source link

Add graceful shutdown #867

Closed wanghaowei0107 closed 5 months ago

wanghaowei0107 commented 6 months ago

868

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 261

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 91.963%

Totals
Change from base Build 247:	-0.1%
Covered Lines:	1968
Relevant Lines:	2140

💛 - Coveralls

oliver006 commented 6 months ago

Thanks for looking into this! How does this fix the issue? The listen call in line 225/227 should block so I don't think we ever down to where you catch the signal.

oliver006 commented 5 months ago

Thanks for updating this PR, this looks a lot better. Did you have a chance to test it? Does it work?

wanghaowei0107 commented 5 months ago

Yes,I did test in local.It's work. By the way, Can you tell me why drone/pr check is always pending on first step? I don't know how to pass this check. Thank you. 微信图片_20240115101136

wanghaowei0107 commented 5 months ago

So when will this feature be released?

oliver006 commented 5 months ago

Released as https://github.com/oliver006/redis_exporter/releases/tag/v1.57.0