search

oliver006 / redis_exporter

Prometheus Exporter for ValKey & Redis Metrics. Supports ValKey and Redis 2.x, 3.x, 4.x, 5.x, 6.x, and 7.x
https://github.com/oliver006/redis_exporter
MIT License
3.12k stars 876 forks source link

fix: compatible with stream entry id metric for redis version 6.x/5.x. #917

Closed gitsang closed 2 months ago

gitsang commented 3 months ago

The entry id in different versions of redis is not always in the 17th and 19th positions of the xinfo stream.

In 6.x and 5.x, first-entry is 11th, last-entry is 13th

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 372

Details

Totals Coverage Status
Change from base Build 367: 0.06%
Covered Lines: 1986
Relevant Lines: 2359
💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 373

Details

Files with Coverage Reduction New Missed Lines %
exporter/streams.go 3 71.43%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 367: -0.07%
Covered Lines: 1983
Relevant Lines: 2359
💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 374

Details

Files with Coverage Reduction New Missed Lines %
exporter/streams.go 3 71.43%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 367: -0.07%
Covered Lines: 1983
Relevant Lines: 2359
💛 - Coveralls
gitsang commented 3 months ago

Already rebase the code and commit:

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 375

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
exporter/streams.go 12 15 80.0%
<!-- Total: 12 15 80.0% -->
Files with Coverage Reduction New Missed Lines %
exporter/streams.go 3 69.8%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 367: -0.2%
Covered Lines: 1982
Relevant Lines: 2361
💛 - Coveralls