arslanbisharat
commented
2 years ago Changes Requested,
Hi there,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
- [ ] You have added node modules in your project directory. Please add them to .gitignore.
- [ ] Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have limited number of code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.
oliverSCZ
I did the following:
Created a new branch, 'add-classes-javascript' from main in accordance with GitHub flow rules.
Added all files required and followed the necessary instructions (.gitignore, .html, .css, test.md, README.md).
Committed files (as required).
Effectively set up a HTML & CSS & JS linter.
Documented my work professionally and added a descriptive README.md file to the project's repository using the template provided.
Used JavaScript classes instead of objects and arrays.
Used objects and arrays inside classes.
Created class methods to add and remove books.
Maintain all of the original functionality of the application (i.e. no bugs were introduced while refactoring).
Opened this pull request as instructed.