oliverbooth / X10D

Extension methods on crack.
https://oliverbooth.github.io/X10D/
MIT License
28 stars 2 forks source link

IReadOnlyDictionary.ToGetParameters joins with incorrect character #48

Closed oliverbooth closed 2 years ago

oliverbooth commented 2 years ago

Describe the bug It would appear that in migrating the extension method to a child namespace as of 9db02497905e07ab972f8da881195e089ab7245a, line 85 has a call to string.Join passing in ;

To Reproduce n/a

Expected behavior This method should join by & not ;, as this is the character used to delimit GET query parameters.

Additional context This is presumably due to my confusion with ToConnectionString, I likely copied and pasted it. :notlikethis: