search

olivercheok20 / pe

0 stars 0 forks source link

Find function returns extra results #2

Open olivercheok20 opened 5 years ago

olivercheok20 commented 5 years ago

Summary

The find function returns extra results when used in the context of appeals (the /a prefix), when searching for resolved appeals. To reproduce the bug, perform the following command: find a/resolved.

Expected Behavior

I would expect only appeals that have been resolved to be returned.

Current Behavior

All appeals are returned, regardless of whether they are resolved or unresolved.

Possible reasons

This may be because the word 'Unresolved' contains the word 'Resolved`.

nus-pe-bot commented 4 years ago

Team's Response

Thank you raising the concern.

As specified in UG, find command searches for "all items containing the keyword as a word or a part of word". Technically, this behavior is specified in UG so that it is expected.

But this bug is accepted since it will cause inconvenience if the admin wants to find resolved appeals.

But severity should be medium or low as it causes a minor inconvenience only. Because the admin is usually more interested in finding unresolved appeals over resolved appeals. The appeals are listed in order of Appeal ID, so it helps the admin to filter out the unresolved appeals to deal with. Whereas when he/she wants to find a resolved appeal, it is more common for he/she to search for more specific keywords such as student or requested modules.

We can try to improve this filtering in v2.0

Below is the screenshot from UG.

Screenshot 2019-11-18 at 11.29.09.png

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.High]. Originally [severity.Medium].

Reason for disagreement: [replace this with your reason]