search

oliverdunk / JukeboxAPI

Java API for Jukebox, my web based music player.
MIT License
19 stars 16 forks source link

Support Cauldron #41

Open oliverdunk opened 5 years ago

oliverdunk commented 5 years ago

We try to use the net/md_5/bungee/api/chat/BaseComponent class which is not available in Cauldron.

Moutard3 commented 5 years ago

Does this affect Sponge too?

oliverdunk commented 5 years ago

It's true that we don't support Sponge, but that's for a different reason, so wouldn't be covered by this issue.

Cauldron is based on Bukkit, so should run MCJukebox. It only doesn't because of some more changes that are needed in our clickable chat links.

Moutard3 commented 5 years ago

Oh okay! Never used any of those two ^^ So would it be better to detect cauldron and use another class, or would it be possible to use another class that the two have?

oliverdunk commented 5 years ago

In theory, I think we should be able to find one that the two share. We can go for the other approach if not, though.

Maybe a better idea is just to get the server version and base our decision on that?

Moutard3 commented 5 years ago

What do you mean with getting the server version?

Edit: Since cauldron is not updated anymore, I think this issue isn't one. Edit2: LavaBukkit seems more viable option

oliverdunk commented 5 years ago

I think in the modding community versions like 1.7 are more common. I could be wrong though.

With the version, I know that /version tells you if you're running Bukkit or Spigot. I hope there's a method for that and it will presumably identify Cauldron too.

Moutard3 commented 5 years ago

Yeah but that's not what i mean. Cauldron development is abandoned so I don't think it's still use by many people as there's some alternatives like LavaBukkit (which support Spigots plugins) & Sponge (which don't afaik). Supporting Cauldron isn't useful imo

oliverdunk commented 5 years ago

Hmm, that'd be interesting to investigate. I haven't heard of LavaBukkit but if that's the case MCJukebox should be tested on that too.

Moutard3 commented 5 years ago

I never tried LavaBukkit, just gave it as it was the only alternative I could find. If possible, a plugin rewrite for sponge would be better I think (but much more time consuming)

GrangerTheDog commented 2 years ago

This should support Cauldron #55