Use pages for region list

oliverdunk / JukeboxAPI

Java API for Jukebox, my web based music player.

MIT License

19 stars 16 forks source link

Closed Moutard3 closed 4 years ago

Moutard3 commented 4 years ago

Fix #46

datdenkikniet commented 4 years ago

The Integer.parseInt() should probably be wrapped in a try-catch block (since that throws NumberFormatException when invalid input is given)

Moutard3 commented 4 years ago

The Integer.parseInt() should probably be wrapped in a try-catch block (since that throws NumberFormatException when invalid input is given)

True. I made a new commit to prevent this.

oliverdunk commented 4 years ago

Thanks again for working on this! I pushed a few changes - feel free to look at the commit.

I kept your overall approach, but made a few tweaks:

REGIONS_PER_PAGE is now a static final constant, to make it easier to find and change.
Slightly updated the header to just "Registered Regions (Page X/Y)".
We no longer show a new line after the last region.
We show a final line when there are more pages, saying what command to run.