Open iceking2001 opened 5 years ago
I will have to review why that is. Maybe it was a temporary problem we were trying to fix. Seems wrong to me as well: fiddling with the URL encoding.
It came in with #962, and was carried over from this client. Can you check if that hack is still required?
Sorry for the late replay. I check three case without this hack:
All of above don't get 403 Forbidden error from aws.
Which version of Elastic are you using?
[x] elastic.v6 (for Elasticsearch 6.x)
Please describe the expected behavior
Get and update a document successed if its id contains both comma and slash.
Please describe the actual behavior
The es return 400 bad request error.
Any steps to reproduce the behavior?
Insert a document by bulk api , which id is "c7ccd3c6f4a7: <Michael.Lee@chi.com/O=, @gg.hop.com", then retrieves this document by GetService api, print its request likes:
the return is:
I notice that if the version <= v6.2.13, there is no such issue. With compare between v6.2.13 and v6.2.14, found that some modify in aws_v4.go cause the problem.
If I comment out this code, it works. It has a correct request, and with the correct url encoding:
So i am curious about what this code does, if comments out them, what will happen?