search

oliverfoster / adapt-v6-prototype

Readme for testing prototype
0 stars 0 forks source link

core plugin issues with brian quinn #1

Open oliverfoster opened 6 years ago

oliverfoster commented 6 years ago

brian:

i was wondering: how does adapt-contrib-core declare its dependency on adapt-contrib-boot?

oliverfoster commented 6 years ago

Well, it doesn't is the short answer. https://github.com/oliverfoster/adapt-contrib-core/blob/master/bower.json#L12 I'm not a fan of adding dependency declarations when they're not absolutely necessary. But in this case there are arguments either way. Boot is the browser normalisation and browser extension plugin... I guess. core should be able to run with a different bootloader. The only part of boot that does have dependency/order declaration requirements is the reset LESS. Which should really be the first thing to get laid down.

oliverfoster commented 6 years ago

brian:

if boot defines Bowser.js as a library, and core's device.js is dependent on that, swapping out another boot for a different bootloader plugin that doesn't have Bowser.js will surely break core?

oliverfoster commented 6 years ago

Yup. But that'd be breaking the API for boot. I'd expect that kind of thing to happen replacing any part with something that breaks a used API. It does kind of demonstrate our need to decide upon and document what is a provided API and what isn't.