oliverjam / workstream-website

The new Workstream X marketing site
6 stars 1 forks source link

Login button to have 'Coming soon' hover over #23

Closed lickcreative closed 7 years ago

lickcreative commented 7 years ago

Needs to say 'Coming soon' on hover or click.

oliverjam commented 7 years ago

How's that?

oliverjam commented 7 years ago

Coming soon doesn't fit super well :/

lickcreative commented 7 years ago

Looks fine to me but I'm not keen on the cursor changing to having the little 'stop' sign on it. Would rather the pointer cursor. If this is not possible, all good, we can close this issue

oliverjam commented 7 years ago

Yeah I just did it for fun to make it obvious it's disabled.

When you say pointer you mean the link cursor? The hand with the finger?

Jamchiller commented 7 years ago

Yep link cursor. Hand with finger. I tried to look up the official name and was on the fence between 'link selector cursor' and 'pointer'

oliverjam commented 7 years ago

I'm not sure that using a link cursor for a button that doesn't go anywhere is a good idea.

https://medium.com/simple-human/buttons-shouldnt-have-a-hand-cursor-b11e99ca374b

Jamchiller commented 7 years ago

Eh I don’t think that’s a consensus opinion. As the guy in the comments says, google uses the pointer for buttons. So do apple, quite often. Medium do, and even the comment button under this box does. So definitely just whether you think you want to provide an affordance

Jamchiller commented 7 years ago

Definitely an interesting article though. One thing I would say is that his clickbaity 'no button should have a hand cursor' comment isn't very nuanced - there are other reasons why you would use it. Using the google search page as an example, which I'm sure has had millions spent on it in UX testing, they've included a hand cursor over the 'tools' button. It has everything the dude has pointed out - it's a button, it has visual feedback and strong affordances, and yet they've applied a hand cursor. I'd say this is mainly for consistency's sake. You have 'all', 'images', etc, that are all links, and hence need a hand cursor. And so it would be weird to have a button next to it that doesn't trigger the hand cursor, because this could cause confusion on whether the button is actually clickable or not. In the same way, I think that since our 'about' and 'contact' have a hand pointer, the button should too

Jamchiller commented 7 years ago

But it's not that important. Kinda just interested by the question. Was not aware that people were pushing for the removal of hand pointers from buttons

oliverjam commented 7 years ago

It's pushing for leaving buttons in their default state. There's a reason links have a special cursor and buttons don't in every browser. Links are a special web thing and have a special cursor to indicate that. Buttons in native apps for example don't use different cursors. Pointers aren't for indicating clickability, they're to indicate that clicking it will take you to another location.

Having thought about it though in this case 'Log In' is just a link that looks like a button. It's going to take you to a totally different webpage right? So it probably makes sense to use a pointer.

I think the takeaway from the article is that you shouldn't just have all your buttons have pointers by default — you need to think about the use-case.

Jamchiller commented 7 years ago

I think you're being a little nice on the writer of the article. Although I agree with him on the whole, he doesn't say 'think about the use-case', he says 'The hand cursor is reserved for links.' Which is the opposite of thinking about the use-case. And none of this addresses the fact that Google break this rule on their most important page.

But cool, yeah you're right, it is a link so defo a hand pointer.

oliverjam commented 7 years ago

Why are Google relevant? They could be wrong just as much as anyone else. I think the definition of wrong here is important.

From my perspective as someone who values the web and the way things are supposed to work this is 'wrong', but it might be 'right' for certain groups of users.

Jamchiller commented 7 years ago

Google are relevant for a number of reasons:

And yes you're right, wrong and right vary based on who you ask, and this is all the more reason why a nuanced approach is better, rather than a 'this is how this should work in all cases' approach.

oliverjam commented 7 years ago

Yeah I guess google.com is probably the most user-tested site in the world.

Staying on topic: I'll push a change to use a pointer instead of the disabled cursor.

Jamchiller commented 7 years ago

Haha okay :) Nice!