search

oliverjam / workstream-website

The new Workstream X marketing site
6 stars 1 forks source link

Add correct video to iPhone #26

Closed oliverjam closed 7 years ago

Jamchiller commented 7 years ago

When the video resets, it seems to show some sort of video controls. Is that a problem with my video or the code?

oliverjam commented 7 years ago

I'm not seeing any controls. Screenshot?

Jamchiller commented 7 years ago

Appears for a couple of seconds

mar-27-2017 10-26-38

Jamchiller commented 7 years ago

Top and bottom

oliverjam commented 7 years ago

Wtf is that. Nothing to do with the browser so it must be in the video. I can't see it when I play the file in Quicktime though. Looks like some kind of mobile sharing menu with a share/edit/delete option.

What phone was it recorded on? I can probably strip the last half second off to get rid of it.

Jamchiller commented 7 years ago

Haha yeah so weird. It looks like it's in the first second, not the last second? But yeah, strip it out if you can

oliverjam commented 7 years ago

Better?

Jamchiller commented 7 years ago

Fixed! Nice!

... Hate to bring up more issues, but it seems the iphone is initially loading in the first section - see this gif. For a split second every time I reload the page, the iphone appears and then is pushed down. Is this fixable?

mar-28-2017 10-11-07

oliverjam commented 7 years ago

I think it's because images are loaded asynchronously, which means the box containing it has 0 height. Because the iPhone is positioned absolutely to the bottom of that box it sticks up above until the image loads. I can give the box a min-height so it doesn't collapse like that.

Jamchiller commented 7 years ago

Awesome. It peeks over the browser for a second, it's kinda cute

oliverjam commented 7 years ago

I think it's fixed now

Jamchiller commented 7 years ago

Looks fixed to me! Whoop. Close this one