search

oliverjrose99 / Recordurbate

A Bot to automatically record Chaturbate live streams.
GNU General Public License v3.0
240 stars 75 forks source link

Log details #78

Open skybarberom opened 2 years ago

skybarberom commented 2 years ago

Is it possible, if not already present, implement a setting with log verbosity? Actually in the log file I see all the output of the is_online() function [2022-10-03 16:04:56,822 bot.py:84 - is_online()]- <Response [200]> [2022-10-03 16:04:56,822 bot.py:85 - is_online()]-

which make the log extremely big, growing fast and hard to read. I understand it is helpful to see what the function returns (I have problem with #76 too, some streamer doesn't show up) but the log become unreadable. Maybe just limit the output to only room name would be easier

divenxx commented 2 years ago

maybe localy you can change https://github.com/oliverjrose99/Recordurbate/blob/3c4ea62fcad3d1ec6ab9bc350d84cbb9403102a6/recordurbate/daemon.py#L23 to self.logger.setLevel(logging.INFO)

leet86 commented 2 years ago

@skybarberom I can work on an update to help improve logging in Recordurbate.

1) The chaturbate default logging level can be set to INFO (instead of DEBUG). 2) Some log statements can be changed to log.debug, to help reduce Info-level log output.

Question is what exactly do we want to see in the Log.info and Log.debug logging levels?

Log.info Recordurbate started Stream started Stream ended Recordurbate stopped

Log.debug (suggestions to add or remove log items?)

skybarberom commented 2 years ago

@skybarberom I can work on an update to help improve logging in Recordurbate.

  1. The chaturbate default logging level can be set to INFO (instead of DEBUG).
  2. Some log statements can be changed to log.debug, to help reduce Info-level log output.

Question is what exactly do we want to see in the Log.info and Log.debug logging levels?

Log.info Recordurbate started Stream started Stream ended Recordurbate stopped

Log.debug (suggestions to add or remove log items?)

I think the log.info would be great with the information you wrote. Regarding log.debug what I saw is that it prints all what is returned by the is_online() function, that generate a log very hard to read. Is the function going to be reverted to the old one as requested in the other issue (not showing all rooms)? Reading the room name may be helpful for debug, but it should be related only to that and not all the attributes. Would be possible to parse the output to insert into the log?