search

oliverklee / ext-realty

TYPO3 extension "realty"
https://www.oliverklee.de/typo3-services/realty-manager/
GNU General Public License v2.0
1 stars 3 forks source link

[Bugfix]: Fix the list plugin showing error in TYPO3 9 #325

Closed fawmi closed 3 years ago

fawmi commented 3 years ago

The TYPO3 9 plugin shows an error, when the plugin is added as content element. The error says "Invalid value [realty_pi1]" The error disappears when I move the call to the ExtensionManagementUtility::addPlugin method to the tt_content file. This PR moves the call to ExtensionManagementUtility::addPlugin tt_content.php file.

oliverklee commented 3 years ago

Thanks for contributing this PR, @fawmi! I'll review it shortly.

fawmi commented 3 years ago

@oliverklee Sorry, wrong changes were committed. I fixed the changes and added a line in the changelogs file.

fawmi commented 3 years ago

@oliverklee Not related to this PR, but there are a few other changes for making this extension TYPO3 10 compatible, which I would like to open a PR for. Is it possible to create a typo3-10 Branch so that I can commit my changes there?

And how is the support policy for the extension, should the version 3.3 (or whatever version it will be) support TYPO3 8 as well?

oliverklee commented 3 years ago

@fawmi I've moved your question to the Discussions section and replied there.

oliverklee commented 3 years ago

@fawmi I have no idea why the V9 tests are running on the CI for this branch. For starters, could you please check that your branch is based on the latest main branch?

fawmi commented 3 years ago

My branch is based on feature/typo3-9. Should i create a PR based on main?

oliverklee commented 3 years ago

My branch is based on feature/typo3-9. Should i create a PR based on main?

Yes, please, always.

oliverklee commented 3 years ago

(You can also rebase and force-push in order to keep this PR.)

oliverklee commented 3 years ago

(The version 9 branch currently is only for seeing what breaks, not for building a 9-compatible version.)

fawmi commented 3 years ago

@oliverklee

In the main branch, the addPlugin is already done in the ext_tables.php file, which also works in TYPO3 9/10 The addPlugin was moved to the ext_localconf in the "472261d7b214fab8180a52f675f17e998875c441".

As far as the changes from features/typo3-9 is not merged in main the plugin works. This PR is also not needed in the main branch.

oliverklee commented 3 years ago

Okay, thanks for checking and reporting back! Closing then.