oliverlalan / Doto

A bitmap inspired, open-source, variable, monospace, geometric typeface family.
SIL Open Font License 1.1
12 stars 1 forks source link

Small fixes to match with the GF specs #2

Closed emmamarichal closed 3 months ago

emmamarichal commented 5 months ago

Hi @oliverlalan!

Again, congrats and thank you for this amazing project! I took a look at the files, and all is almost perfect.

A few things to update:

Don't hesitate if you have any questions :) Cheers!

Screenshot 2024-04-25 at 14 45 19 Screenshot 2024-04-25 at 14 47 32

Example of caron:

Screenshot 2024-04-25 at 14 53 14
oliverlalan commented 4 months ago

Hello @emmamarichal,

I am back on track with this!

A few comments:

To maintain the style, it’s critical that the dots fit into the 6x10 grid. Here are three options, each with its own drawbacks:

emmamarichal commented 4 months ago

Hi @oliverlalan, Thank you for your patience!

We think it's indeed better to keep an actual monospace. But on the other hand, we found a bit weird to have these kind of "space" issue. We can suggest to

Let me know what you think about that :)

oliverlalan commented 3 months ago

Hello @emmamarichal,

I would discard the "double" width option for two reasons: First, the problematic glyphs would look way too spaced. And second, and most important, the font would not be technically "monospaced" anymore (I am not a font engineer, but I am quite sure fontbakery checks all glyphs have the same width when the font tables are flagged as monospace).

I would go with the redesign and exceptions alternative. Here it is my proposal: Pasted image 20240617163639

If you are ok with it, confirm it, and I will update the characters marked with green and yellow, left the red ones as they are, and let you know when all the other issues are closed.

Regards!

emmamarichal commented 3 months ago

Hi @oliverlalan! I'm ok with that, you can go ahead :) Let me know once it's ready to review and onboard! I'll then fork your repo and send you a PR if I need to bring corrections during my QA! Thank you!

oliverlalan commented 3 months ago

Hello @emmamarichal !

The font has been updated with all the requested changes (repository and issue renaming included).

You can already fork and do the font QA.

Just let me know if there is anything else you need from my side.

Regards!

emmamarichal commented 3 months ago

Excellent, thanks a lot, I'll take a look asap :)