search

oliverlloyd / jmeter-ec2

Automates running Apache JMeter on Amazon EC2
GNU General Public License v3.0
464 stars 186 forks source link

Some minor generalisations with added region support #4

Closed gerricchaplin closed 12 years ago

gerricchaplin commented 12 years ago

Very nice work on this tool!! You have made something great here. ;) I would like to submit the following few changes in case others might find them useful.

install.sh uses jmeter-ec2.properties to define JAVA_VERSION for 32 and 64 bit

Add AMAZON_KEYPAIR_NAME so that PEM_FILE can reference any file as we may be using a rya key and the name might not match the key pair name in AWS. Add region property so that users can actually spark something up in a different regions and AZ like eh-west-1b.

Add JAVA_VERSIONs for 32 and 64bit used by install.sh

jmeter-ec.sh add region and support to commands remove .pem from PEM_FILE name as it is not necessary now using PEM_FILE. SCP some more files up like the stop script that I had to modify to explicitly look at my java dir. Likely an issue with PATHs but haven't had much luck fixing it as yet. profile.d config was correct… Add meter.sh and stoptest.sh as it wasn't using the JAVA_HOME I had configured.

oliverlloyd commented 12 years ago

Had to manually merge this due to conflicts - thanks for the update.