olivernn
commented
8 years ago Well I learnt something today! I guess it makes sense that there is an upper limit on the number of parameters, I doubt many people ever run into it though.
It seems strange to me that lunr.SortedSet.prototype.add iterates through a list of input elements at all. I'm trying to remember why it was originally like this but can't think of anything.
Ideally I'd like to change the signature of lunr.SortedSet.prototype.add to only accept one item at a time. This would also remove the use of arguments in the implementation which is likely going to give us a slight performance boost also. It would be backwards incompatible though and so we should probably hold off on that change for now.
Instead when we call it internally we can treat it like it only accepts one element and do all the iteration in the calling scope. Does that make sense? For example, instead of:
lunr.SortedSet.prototype.add.apply(this.corpusTokens, allDocumentTokens.toArray())we would have something like this:
for (var i = 0, tokens = allDocumentTokens.toArray(), len = tokens.length; i < len; i++) {
this.corpusTokens.add(tokens[i])
}In fact, it looks like we are already iterating over the allDocumentTokens in the very next line.
Perhaps also fix this case of using apply also.
Also, please take a look at the contributing guide. Specifically changes should only be made in the files in lib, in this case it looks like the index file is what you want.
dangrie158
d0ugal
Before this fix, the index passed all tokens via an apply call, pushing all parameters on the stack. This behaviour causes a RangeError when more tokens are added than the JS implementation can handle.
This fix changes the code so that now an explicit Array is passed instead of pushing the values of the array on the stack.
Some Tests on the maximum Stack size using the suggested method from http://stackoverflow.com/questions/22747068/is-there-a-max-number-of-arguments-javascript-functions-can-accept: